lkml.org 
[lkml]   [2013]   [Apr]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [Cluster-devel] [PATCH v3 08/18] gfs2: use ->invalidatepage() length argument
    From
    Date
    Hi,

    On Tue, 2013-04-09 at 11:14 +0200, Lukas Czerner wrote:
    > ->invalidatepage() aop now accepts range to invalidate so we can make
    > use of it in gfs2_invalidatepage().
    >
    > Signed-off-by: Lukas Czerner <lczerner@redhat.com>
    > Cc: cluster-devel@redhat.com
    Acked-by: Steven Whitehouse <swhiteho@redhat.com>

    Steve.

    > ---
    > fs/gfs2/aops.c | 9 +++++++--
    > 1 files changed, 7 insertions(+), 2 deletions(-)
    >
    > diff --git a/fs/gfs2/aops.c b/fs/gfs2/aops.c
    > index 37093ba..ea920bf 100644
    > --- a/fs/gfs2/aops.c
    > +++ b/fs/gfs2/aops.c
    > @@ -947,24 +947,29 @@ static void gfs2_invalidatepage(struct page *page, unsigned int offset,
    > unsigned int length)
    > {
    > struct gfs2_sbd *sdp = GFS2_SB(page->mapping->host);
    > + unsigned int stop = offset + length;
    > + int partial_page = (offset || length < PAGE_CACHE_SIZE);
    > struct buffer_head *bh, *head;
    > unsigned long pos = 0;
    >
    > BUG_ON(!PageLocked(page));
    > - if (offset == 0)
    > + if (!partial_page)
    > ClearPageChecked(page);
    > if (!page_has_buffers(page))
    > goto out;
    >
    > bh = head = page_buffers(page);
    > do {
    > + if (pos + bh->b_size > stop)
    > + return;
    > +
    > if (offset <= pos)
    > gfs2_discard(sdp, bh);
    > pos += bh->b_size;
    > bh = bh->b_this_page;
    > } while (bh != head);
    > out:
    > - if (offset == 0)
    > + if (!partial_page)
    > try_to_release_page(page, 0);
    > }
    >




    \
     
     \ /
      Last update: 2013-04-09 12:21    [W:2.754 / U:0.032 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site