Messages in this thread | | | From | Rusty Russell <> | Subject | Re: [PATCH] MODSIGN: do not send garbage to stderr when enabling modules signature | Date | Tue, 09 Apr 2013 12:57:53 +0930 |
| |
David Cohen <david.a.cohen@intel.com> writes: > openssl may send garbage to stderr when generating X.509 key pair for > modules signature regardless there was an error or not. It makes more > difficult to create scripts based on kernel error/warning messages. > This patch makes sure openssl logs go to default stdout. > > Signed-off-by: David Cohen <david.a.cohen@intel.com>
Can you please give an example of the "garbage" in your commit message, or is it binary?
Thanks, Rusty,.
> --- > kernel/Makefile | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/kernel/Makefile b/kernel/Makefile > index bbde5f1..5a51e6c 100644 > --- a/kernel/Makefile > +++ b/kernel/Makefile > @@ -175,7 +175,7 @@ signing_key.priv signing_key.x509: x509.genkey > openssl req -new -nodes -utf8 -$(CONFIG_MODULE_SIG_HASH) -days 36500 \ > -batch -x509 -config x509.genkey \ > -outform DER -out signing_key.x509 \ > - -keyout signing_key.priv > + -keyout signing_key.priv 2>&1 > @echo "###" > @echo "### Key pair generated." > @echo "###" > -- > 1.7.10.4
| |