lkml.org 
[lkml]   [2013]   [Apr]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 1/1] irqchip: exynos-combiner: Fix checkpatch warnings
From
Date
On Tue, 2013-04-09 at 08:33 +0530, Sachin Kamat wrote:
> On 13 March 2013 14:42, Sachin Kamat <sachin.kamat@linaro.org> wrote:
> > Fixes the following warnings:
> > WARNING: line over 80 characters
> > WARNING: Prefer pr_warn(... to pr_warning(...
> > diff --git a/drivers/irqchip/exynos-combiner.c b/drivers/irqchip/exynos-combiner.c
[]
> > @@ -229,13 +229,15 @@ void __init combiner_init(void __iomem *combiner_base,
[]
> > - pr_warning("%s: irq desc alloc failed. Continuing with %d as linux irq base\n", __func__, irq_base);
> > + pr_warn("%s: irq desc alloc failed. "
> > + "Continuing with %d as linux irq base\n",
> > + __func__, irq_base);

Please don't split formats.
See Documentation/CodingStyle Chapter 2

pr_warn("%s: irq desc alloc failed. Continuing with %d as linux irq base\n",
__func__, irq_base);




\
 
 \ /
  Last update: 2013-04-09 06:01    [W:1.350 / U:0.008 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site