Messages in this thread | | | Date | Mon, 8 Apr 2013 13:57:39 -0700 | From | Andrew Morton <> | Subject | Re: [PATCH v8 3/3] mm: reinititalise user and admin reserves if memory is added or removed |
| |
On Mon, 8 Apr 2013 15:07:38 -0400 Andrew Shewmaker <agshew@gmail.com> wrote:
> This patch alters the admin and user reserves of the previous patches > in this series when memory is added or removed. > > If memory is added and the reserves have been eliminated or increased above > the default max, then we'll trust the admin. > > If memory is removed and there isn't enough free memory, then we > need to reset the reserves. > > Otherwise keep the reserve set by the admin. > > The reserve reset code is the same as the reserve initialization code. > > Does this sound reasonable to other people? I figured that hot removal > with too large of memory in the reserves was the most important case > to get right. > > I tested hot addition and removal by triggering it via sysfs. The reserves > shrunk when they were set high and memory was removed. They were reset > higher when memory was added again.
I have added your Signed-off-by: to my copy of this patch.
| |