Messages in this thread Patch in this message | | | Date | Mon, 08 Apr 2013 12:38:40 -0700 | From | Dave Hansen <> | Subject | Re: [PATCHv3, RFC 09/34] thp: represent file thp pages in meminfo and friends |
| |
On 04/05/2013 04:59 AM, Kirill A. Shutemov wrote: > The patch adds new zone stat to count file transparent huge pages and > adjust related places. > > For now we don't count mapped or dirty file thp pages separately.
I can understand tracking NR_FILE_TRANSPARENT_HUGEPAGES itself. But, why not also account for them in NR_FILE_PAGES? That way, you don't have to special-case each of the cases below:
> --- a/fs/proc/meminfo.c > +++ b/fs/proc/meminfo.c > @@ -41,6 +41,9 @@ static int meminfo_proc_show(struct seq_file *m, void *v) > > cached = global_page_state(NR_FILE_PAGES) - > total_swapcache_pages() - i.bufferram; > + if (IS_ENABLED(CONFIG_TRANSPARENT_HUGEPAGE)) > + cached += global_page_state(NR_FILE_TRANSPARENT_HUGEPAGES) * > + HPAGE_PMD_NR; > if (cached < 0) > cached = 0; .... > --- a/mm/mmap.c > +++ b/mm/mmap.c > @@ -135,6 +135,9 @@ int __vm_enough_memory(struct mm_struct *mm, long pages, int cap_sys_admin) > if (sysctl_overcommit_memory == OVERCOMMIT_GUESS) { > free = global_page_state(NR_FREE_PAGES); > free += global_page_state(NR_FILE_PAGES); > + if (IS_ENABLED(CONFIG_TRANSPARENT_HUGEPAGE)) > + free += global_page_state(NR_FILE_TRANSPARENT_HUGEPAGES) > + * HPAGE_PMD_NR; ... > - printk("%ld total pagecache pages\n", global_page_state(NR_FILE_PAGES)); > + cached = global_page_state(NR_FILE_PAGES); > + if (IS_ENABLED(CONFIG_TRANSPARENT_HUGEPAGE)) > + cached += global_page_state(NR_FILE_TRANSPARENT_HUGEPAGES) * > + HPAGE_PMD_NR; > + printk("%ld total pagecache pages\n", cached);
| |