Messages in this thread | | | From | Arnd Bergmann <> | Subject | Re: [PATCH 4/5] dmaengine: ste_dma40: Only configure a channel during a configure request | Date | Mon, 8 Apr 2013 18:19:46 +0200 |
| |
On Monday 08 April 2013, Lee Jones wrote: > According to the DMA documentation allocating a channel and configuring > it are two separate actions. By moving the configuration code into the > correct code path we lighten the burden on the information required to > successfully allocate a channel. > > Cc: Vinod Koul <vinod.koul@intel.com> > Cc: Dan Williams <djbw@fb.com> > Cc: Per Forlin <per.forlin@stericsson.com> > Signed-off-by: Lee Jones <lee.jones@linaro.org>
I think the patch doesn't match the description. You only remove the calls to configure the channel but don't add it in a proper place.
Arnd
| |