Messages in this thread | | | Date | Mon, 8 Apr 2013 16:50:03 +0200 | From | Borislav Petkov <> | Subject | Re: [PATCH V3] iommu/amd: Add logic to decode AMD IOMMU event flag |
| |
On Mon, Apr 08, 2013 at 02:33:32PM +0000, Suthikulpanit, Suravee wrote: > Joerg, > > Do you have any more feedback about this patch? > > Thanks, > > Suravee > ________________________________________ > From: suravee.suthikulpanit@amd.com [suravee.suthikulpanit@amd.com] > Sent: Tuesday, April 02, 2013 7:06 PM > To: iommu@lists.linux-foundation.org; joro@8bytes.org > Cc: linux-kernel@vger.kernel.org; Suthikulpanit, Suravee > Subject: [PATCH V3] iommu/amd: Add logic to decode AMD IOMMU event flag > > From: Suravee Suthikulpanit <suravee.suthikulpanit@amd.com> > > Add logic to decode AMD IOMMU event flag based on information from AMD IOMMU specification. > This should simplify debugging IOMMU errors. Also, dump DTE information in additional cases. > > This is an example: > AMD-Vi: Event logged [IO_PAGE_FAULT device=51:00.0 domain=0x0000 address=0x0000000000000000 flags=0x0fff] > AMD-Vi: Flags details: Guest NX=1 User Intr Present Write No-Perm Rsrv-Bit Translation > AMD-Vi: Type of error: (0x7) > AMD-Vi: (Note: Please refer to AMD IOMMU specification for details.)
Independent from Joerg's feedback on this, I have only one question: you're not seriously considering on dumping this "Note:..." line above on *every* IO-PF, right?
I very positively assume that people who stare at that output should, as a first prerequisite, know where to find those fields' descriptions. :-)
Thanks.
-- Regards/Gruss, Boris.
Sent from a fat crate under my desk. Formatting is fine. --
| |