lkml.org 
[lkml]   [2013]   [Apr]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] AVR32: fix building warnings caused by redifinitions of HZ
Around Sun 07 Apr 2013 23:29:17 +0800 or thereabout, Jiang Liu wrote:
> On 04/07/2013 03:55 PM, Hans-Christian Egtvedt wrote:
>> Around Sun 07 Apr 2013 00:43:36 +0800 or thereabout, Jiang Liu wrote:
>>> Fix building warnings caused by redifinitions of HZ:

<snipp warning>

>> Thanks for fixing.
>>
>>> Signed-off-by: Jiang Liu <jiang.liu@huawei.com>
>>> Cc: Haavard Skinnemoen <hskinnemoen@gmail.com>
>>> Cc: Hans-Christian Egtvedt <egtvedt@samfundet.no>
>>> Cc: linux-kernel@vger.kernel.org
>>
>> Acked-by: Hans-Christian Egtvedt <egtvedt@samfundet.no>
>>
>>> ---
>>> arch/avr32/include/uapi/asm/param.h | 6 +++++-
>>> 1 file changed, 5 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/arch/avr32/include/uapi/asm/param.h b/arch/avr32/include/uapi/asm/param.h
>>> index d28aa5e..abda103 100644
>>> --- a/arch/avr32/include/uapi/asm/param.h
>>> +++ b/arch/avr32/include/uapi/asm/param.h
>>> @@ -2,7 +2,11 @@
>>> #define _UAPI__ASM_AVR32_PARAM_H
>>>
>>>
>>> -#ifndef HZ
>>> +#ifndef __KERNEL__
>>> + /*
>>> + * Technically, this is wrong, but some old apps still refer to it.
>>> + * The proper way to get the HZ value is via sysconf(_SC_CLK_TCK).
>>> + */
>>
>> With this comment, are there AVR32 drivers/users that should be fixed? Or is
>> it parts of the tree in general?
> Hi Hans,
> It's copied from arch/ia64/include/uapi/asm/param.h, I feel it should be
> the same for AVR32 too.

Most likely yes, the original param.h header file was added by David Howells
from RedHat, and has never been touched since.

Again, thanks for fixing.

--
mvh
Hans-Christian Egtvedt


\
 
 \ /
  Last update: 2013-04-08 09:41    [W:0.035 / U:2.176 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site