lkml.org 
[lkml]   [2013]   [Apr]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 020/102] udf: Fix bitmap overflow on large filesystems with small block size
    Date
    3.5.7.10 -stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Jan Kara <jack@suse.cz>

    commit 89b1f39eb4189de745fae554b0d614d87c8d5c63 upstream.

    For large UDF filesystems with 512-byte blocks the number of necessary
    bitmap blocks is larger than 2^16 so s_nr_groups in udf_bitmap overflows
    (the number will overflow for filesystems larger than 128 GB with
    512-byte blocks). That results in ENOSPC errors despite the filesystem
    has plenty of free space.

    Fix the problem by changing s_nr_groups' type to 'int'. That is enough
    even for filesystems 2^32 blocks (UDF maximum) and 512-byte blocksize.

    Reported-and-tested-by: v10lator@myway.de
    Signed-off-by: Jan Kara <jack@suse.cz>
    Signed-off-by: Luis Henriques <luis.henriques@canonical.com>
    ---
    fs/udf/udf_sb.h | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/fs/udf/udf_sb.h b/fs/udf/udf_sb.h
    index 42ad69a..9e8e08e 100644
    --- a/fs/udf/udf_sb.h
    +++ b/fs/udf/udf_sb.h
    @@ -82,7 +82,7 @@ struct udf_virtual_data {
    struct udf_bitmap {
    __u32 s_extLength;
    __u32 s_extPosition;
    - __u16 s_nr_groups;
    + int s_nr_groups;
    struct buffer_head **s_block_bitmap;
    };

    --
    1.8.1.2


    \
     
     \ /
      Last update: 2013-04-08 13:02    [W:2.334 / U:0.044 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site