Messages in this thread | | | Date | Sun, 7 Apr 2013 10:59:18 -0700 (PDT) | From | Dan Magenheimer <> | Subject | RE: [PATCH part2 v6 0/3] staging: zcache: Support zero-filled pages more efficiently |
| |
> From: Dan Magenheimer > Subject: RE: [PATCH part2 v6 0/3] staging: zcache: Support zero-filled pages more efficiently > > > From: Wanpeng Li [mailto:liwanp@linux.vnet.ibm.com] > > Subject: Re: [PATCH part2 v6 0/3] staging: zcache: Support zero-filled pages more efficiently > > > > Hi Dan, > > > > Some issues against Ramster: > > > > Sure! I am concerned about Konrad's patches adding debug.c as they > add many global variables. They are only required when ZCACHE_DEBUG > is enabled so they may be ok. If not, adding ramster variables > to debug.c may make the problem worse.
Oops, I just noticed/remembered that ramster uses BOTH debugfs and sysfs. The sysfs variables are all currently required, i.e. for configuration so should not be tied to debugfs or a DEBUG config option. However, if there is a more acceptable way to implement the function of those sysfs variables, that would be fine.
Thanks, Dan
| |