lkml.org 
[lkml]   [2013]   [Apr]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH] mmc: mxs-mmc: Add support for non-removable cards
Date
Dear Alexandre Pereira da Silva,

> Some boards and card slots doesn't have card detect feature available.
> In that case allow to mark the cards as non-removable, via devicetree.
>
> Signed-off-by: Alexandre Pereira da Silva <aletes.xgr@gmail.com>

Looks good,

Reviewed-by: Marek Vasut <marex@denx.de>

btw. did you know you can let git send-email automatically handle CC for you so
you don't have to type it into the command line by simply sticking

Cc: Us Er <e@ma.il>

in the commit message? Preferably under the SoB line.

> ---
> drivers/mmc/host/mxs-mmc.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/drivers/mmc/host/mxs-mmc.c b/drivers/mmc/host/mxs-mmc.c
> index 4efe302..7d2cd74 100644
> --- a/drivers/mmc/host/mxs-mmc.c
> +++ b/drivers/mmc/host/mxs-mmc.c
> @@ -95,6 +95,9 @@ static int mxs_mmc_get_cd(struct mmc_host *mmc)
> struct mxs_mmc_host *host = mmc_priv(mmc);
> struct mxs_ssp *ssp = &host->ssp;
>
> + if (mmc->caps & MMC_CAP_NONREMOVABLE)
> + return 1;
> +
> return !(readl(ssp->base + HW_SSP_STATUS(ssp)) &
> BM_SSP_STATUS_CARD_DETECT);
> }
> @@ -691,6 +694,9 @@ static int mxs_mmc_probe(struct platform_device *pdev)
> if (flags & OF_GPIO_ACTIVE_LOW)
> host->wp_inverted = 1;
>
> + if (of_find_property(np, "non-removable", NULL))
> + mmc->caps |= MMC_CAP_NONREMOVABLE;
> +
> mmc->f_min = 400000;
> mmc->f_max = 288000000;
> mmc->ocr_avail = MMC_VDD_32_33 | MMC_VDD_33_34;

Best regards,
Marek Vasut


\
 
 \ /
  Last update: 2013-04-05 09:01    [W:0.156 / U:0.068 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site