lkml.org 
[lkml]   [2013]   [Apr]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] cpufreq/intel_pstate: Set timer timeout correctly


On Fri, 5 Apr 2013, Viresh Kumar wrote:

> On Thu, Apr 4, 2013 at 11:05 PM, <dirk.brandewie@gmail.com> wrote:
> > From: Dirk Brandewie <dirk.brandewie@gmail.com>
> >
> > The current calculation of the delay time is wrong and a cut and paste
> > error from a previous experimental driver. This can result in the
> > timeout being set to jiffies + 1 which setup the driver to race with
> > it's self if the apic timer interrupt happen at just the right time.
> >
> >
> > https://bugzilla.redhat.com/show_bug.cgi?id=920289
> >
> > Reported-by: Adam Williamson <awilliam@redhat.com>
> > Reported-by: Parag Warudkar <parag.lkml@gmail.com>
> >
> > Signed-off-by: Dirk Brandewie <dirk.brandewie@gmail.com>
> > ---
> > drivers/cpufreq/intel_pstate.c | 1 -
> > 1 files changed, 0 insertions(+), 1 deletions(-)
>
> Looks fine, but I would like to see a Tested-by from Adam/Parag
> as they haven't said anything about this patch (even in bugzilla).
>

I am running with the patch since yesterday - everything looks good.

The issue hasn't been reproducible on demand but some code reading and
Dirk's explanation says the patch should fix the issue.

So - Tested-by: Parag Warudkar <parag.lkml@gmail.com>

Parag


\
 
 \ /
  Last update: 2013-04-06 02:22    [W:0.049 / U:0.244 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site