Messages in this thread | | | Date | Fri, 5 Apr 2013 14:06:05 -0700 | From | Greg Kroah-Hartman <> | Subject | Re: [PATCH v2] RAPL (Running Average Power Limit) driver |
| |
On Fri, Apr 05, 2013 at 02:02:03PM -0700, Jacob Pan wrote: > Changes since V2: > - use 'struct device' instead of raw kobject to represent > RAPL domains > - changed eventfd control interface to use event string > instead of passing file descriptors that cannot be > authenticated in sysfs directory > - clean ups based on v1 reviews > - use kcalloc for arrays > - drop dependencies on X86 > - misc cleanups
Please no, split this up into at least 2 patches, the first being the "standard" thermal driver, and the rest for the "custom" extensions you are proposing.
That way the first can get accepted easily, and into 3.10 (hopefully), so people can use it and not stall everything as we continue to iterate over the "custom" things.
As is, this driver isn't acceptable, sorry.
greg k-h
| |