Messages in this thread | | | Date | Fri, 5 Apr 2013 15:03:03 -0700 | From | Greg Kroah-Hartman <> | Subject | Re: [PATCH] staging/adt7316 Fix some 'interesting' string operations |
| |
On Thu, Apr 04, 2013 at 02:37:24PM -0700, Luck, Tony wrote: > Calling memcmp() to check the value of the first byte in a string is overkill. > Just use buf[0] == '1' or buf[0] != '1' as appropriate. > > Signed-off-by: Tony Luck <tony.luck@intel.com>
I'll let Jonathan take this through his tree which eventually makes it to mine.
thanks,
greg k-h
| |