Messages in this thread | | | Date | Fri, 05 Apr 2013 16:41:48 -0400 | From | KOSAKI Motohiro <> | Subject | Re: [PATCH 02/10] migrate: make core migration code aware of hugepage |
| |
>>> There doesn't seem to be any caller for this function. Please move it to >>> the patch which uses it. >> >> I would do like that if there's only one user of this function, but I thought >> that it's better to separate this part as changes of common code >> because this function is commonly used by multiple users which are added by >> multiple patches later in this series. > > Sure there is no hard rule for this. I just find it much easier to > review if there is a caller of introduced functionality. In this > particular case I found out only later that many migrate_pages callers > were changed to use mograte_movable_pages and made the > putback_movable_pages cleanup inconsistent between the two. > > It would help to mention what is the planned future usage of the > introduced function if you prefer to introduce it without users.
I strong agree with Michal.
| |