Messages in this thread | | | Subject | Re: [PATCH] nfc: Remove useless Makefile line | From | Joe Perches <> | Date | Fri, 05 Apr 2013 09:46:53 -0700 |
| |
On Fri, 2013-04-05 at 18:39 +0200, Paul Bolle wrote: > On Fri, 2013-04-05 at 09:35 -0700, Joe Perches wrote: > > On Fri, 2013-04-05 at 18:31 +0200, Paul Bolle wrote: > > > -ccflags-$(CONFIG_NFC_DEBUG) := -DDEBUG > > > > pr_debug/dev_dbg/nfc_dev_dbg logging messages > > depend on this. > > Thanks. But then a NFC_DEBUG symbol needs to be added, because now the > DEBUG macro will never be set, won't it?
Probably right.
I think all the nfc_dev_<level> uses are unsightly too. Almost all the nfc_dev_dbg uses are functdion enter/leave logging and should be done via the function tracer.
I'll submit some patches for that.
| |