lkml.org 
[lkml]   [2013]   [Apr]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] MFD: rtsx_pcr, fix probe fail path
Hi Jiry,

On Thu, Apr 04, 2013 at 09:34:11PM +0200, Jiri Slaby wrote:
> When rtsx_pci_acquire_irq fails in rtsx_pci_probe, we forget to
> disable an MSI (if we enabled it). This results in this warning on the
> next attempt to load the module:
> WARNING: at drivers/pci/msi.c:834 pci_enable_msi_block+0x2a4/0x2b0()
> Hardware name: HP EliteBook 840 G1
> Modules linked in: rtsx_pci(+) ...
> Pid: 4056, comm: modprobe Tainted: G I 3.8.0-9405-gd895cb1-1-vanilla #1
> Call Trace:
> [<ffffffff81045c6a>] warn_slowpath_common+0x7a/0xc0
> [<ffffffff81045cc5>] warn_slowpath_null+0x15/0x20
> [<ffffffff81302544>] pci_enable_msi_block+0x2a4/0x2b0
> [<ffffffffa05e335a>] rtsx_pci_probe+0x55a/0x720 [rtsx_pci]
> ...
>
> So properly disable MSI in that case.
>
> Signed-off-by: Jiri Slaby <jslaby@suse.cz>
> ---
> drivers/mfd/rtsx_pcr.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
Applied to mfd-next, thanks.

Cheers,
Samuel.

--
Intel Open Source Technology Centre
http://oss.intel.com/


\
 
 \ /
  Last update: 2013-04-05 19:21    [W:2.189 / U:0.248 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site