Messages in this thread | | | Date | Thu, 4 Apr 2013 09:13:09 +0200 | From | Martin Schwidefsky <> | Subject | Re: [PATCH 3/7] dump_stack: consolidate dump_stack() implementations and unify their behaviors |
| |
On Wed, 3 Apr 2013 12:14:53 -0700 Tejun Heo <tj@kernel.org> wrote:
> v2: CPU number added to the generic debug info as requested by s390 > folks and dropped the s390 specific dump_stack(). This loses %ksp > from the debug message which the maintainers think isn't important > enough to keep the s390-specific dump_stack() implementation. > > dump_stack_print_info() is moved to kernel/printk.c from > lib/dump_stack.c. Because linkage is per objecct file, > dump_stack_print_info() living in the same lib file as generic > dump_stack() means that archs which implement custom dump_stack() > - at this point, only blackfin - can't use dump_stack_print_info() > as that will bring in the generic version of dump_stack() too. v1 > The v1 patch broke build on blackfin due to this issue. The build > breakage was reported by Fengguang Wu.
For the s390 changes: Acked-by: Martin Schwidefsky <schwidefsky@de.ibm.com>
-- blue skies, Martin.
"Reality continues to ruin my life." - Calvin.
| |