lkml.org 
[lkml]   [2013]   [Apr]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH v2 05/20] x86, ACPI: Split acpi_initrd_override to find/copy two functions
From
On Thu, Apr 4, 2013 at 11:07 AM, Tejun Heo <tj@kernel.org> wrote:
>>
>> Also move down two functions declaration to avoid #ifdef in setup.c
>>
>> ACPI_INITRD_TABLE_OVERRIDE depends one ACPI and BLK_DEV_INITRD.
>> So could move declaration out from #ifdef CONFIG_ACPI protection.
>
> Heh, I couldn't really follow the above. How about something like the
> following.
>
> While a dummy version of acpi_initrd_override() was defined when
> !CONFIG_ACPI_INITRD_TABLE_OVERRIDE, the prototype and dummy version
> were conditionalized inside CONFIG_ACPI. This forced setup_arch() to
> have its own #ifdefs around acpi_initrd_override() as otherwise build
> would fail when !CONFIG_ACPI. Move the prototypes and dummy
> implementations of the newly split functions below CONFIG_ACPI block
> in acpi.h so that we can do away with #ifdefs in its user.

update changelog with your changes.

Thanks

Yinghai


\
 
 \ /
  Last update: 2013-04-04 22:21    [W:0.384 / U:0.112 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site