Messages in this thread | | | Subject | Re: [PATCH] Blackfin: bf537: rename "CONFIG_ADT75" | From | Paul Bolle <> | Date | Thu, 04 Apr 2013 14:59:43 +0200 |
| |
On Thu, 2013-04-04 at 05:07 -0700, Guenter Roeck wrote: > On Thu, Apr 04, 2013 at 01:40:03PM +0200, Jean Delvare wrote: > > This breakage is telling us something about the weird approach taken in > > this file, methinks. > > > Yes, they have persistent problems with renamed or moved drivers. I somewhat > understood the need for SPI chips, but even there it seemed to me there should > be a better solution.
The output of the (local) scripts I use mention about a dozen more (possible) problems in both Blackfin's stamp.c files. I'm roughly working my way back in git history, slowly, so those problems are probably older.
Since I know from previous cleaning up efforts that the Blackfin people know they have non-working code (eg, code not actually buildable since it has no working Kconfig support) I do not give Blackfin much priority. But this patch (and the other two related to the v3.2 release) were obvious oversights that I could as well fix right away.
Paul Bolle
| |