lkml.org 
[lkml]   [2013]   [Apr]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] Blackfin: bf537: rename "CONFIG_ADT75"
From
Date
On Thu, 2013-04-04 at 05:07 -0700, Guenter Roeck wrote:
> On Thu, Apr 04, 2013 at 01:40:03PM +0200, Jean Delvare wrote:
> > This breakage is telling us something about the weird approach taken in
> > this file, methinks.
> >
> Yes, they have persistent problems with renamed or moved drivers. I somewhat
> understood the need for SPI chips, but even there it seemed to me there should
> be a better solution.

The output of the (local) scripts I use mention about a dozen more
(possible) problems in both Blackfin's stamp.c files. I'm roughly
working my way back in git history, slowly, so those problems are
probably older.

Since I know from previous cleaning up efforts that the Blackfin people
know they have non-working code (eg, code not actually buildable since
it has no working Kconfig support) I do not give Blackfin much priority.
But this patch (and the other two related to the v3.2 release) were
obvious oversights that I could as well fix right away.


Paul Bolle



\
 
 \ /
  Last update: 2013-04-04 21:41    [W:0.055 / U:0.784 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site