Messages in this thread | | | Subject | Re: [RFC] perf: need to expose sched_clock to correlate user samples with kernel samples | From | Pawel Moll <> | Date | Thu, 04 Apr 2013 17:33:22 +0100 |
| |
On Thu, 2013-04-04 at 08:37 +0100, Richard Cochran wrote: > > I get the reasoning around reusing the fd we already have, but is > > the possibility of a dynamic chardev pathname really a big concern? > > I have been following this thread, and, not knowing very much about > perf, I would think that the userland can easily open a second file > (the dynamic posix clock chardev) in order to get these time stamps.
Sure it can - I've tested it. It's just a bit cumbersome in my opinion (there is nothing else perf-related in /dev). I can agree to disagree if you think otherwise :-)
> > Maybe can we extend the dynamic posix clock code to work on more > > then just the chardev? Although I worry about multiplexing too much > > functionality on the file. > > I don't yet see a need for that, but if we do, then it should work in > a generic way, and not as a list of special cases, like we saw in the > patch.
By all means - and even more generic way than it is now (why character devices not any other file?). I'll give it a try.
Paweł
-- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |