Messages in this thread | | | Date | Thu, 04 Apr 2013 15:17:25 +0900 | From | Masami Hiramatsu <> | Subject | Re: [PATCH 2/4] kprobes: split blacklist into common and arch |
| |
(2013/04/03 17:28), oskar.andero@sonymobile.com wrote: > Some blackpoints are only valid for specific architectures. To let each > architecture specify its own blackpoints the list has been split in two > lists: common and arch. The common list is kept in kernel/kprobes.c and > the arch list is kept in the arch/ directory.
Hmm, I think you'd better merge this with patch 3/4.
[...] > +static const size_t common_kprobes_blacksyms_size = > + ARRAY_SIZE(common_kprobes_blacksyms); > + > +extern const char * const arch_kprobes_blacksyms[]; > +extern const size_t arch_kprobes_blacksyms_size; > + > +static struct kprobe_blackpoint **kprobe_blacklist; > +static size_t kprobe_blacklist_size;
Since the blacklist is allocated once and never be updated, we just need an array of struct kprobe_blackpoint, no need to allocate each entry.
Other parts are good for me! :)
Thank you!
-- Masami HIRAMATSU IT Management Research Dept. Linux Technology Center Hitachi, Ltd., Yokohama Research Laboratory E-mail: masami.hiramatsu.pt@hitachi.com
| |