Messages in this thread | | | Date | Thu, 4 Apr 2013 14:26:48 +0530 | From | Kishon Vijay Abraham I <> | Subject | Re: [PATCH v5 1/6] drivers: phy: add generic PHY framework |
| |
Hi,
On Wednesday 03 April 2013 09:17 PM, Felipe Balbi wrote: > Hi, > > On Wed, Apr 03, 2013 at 08:02:52PM +0530, Kishon Vijay Abraham I wrote: >>>>>> + ret = -EINVAL; >>>>>> + goto err0; >>>>>> + } >>>>>> + >>>>>> + if (!phy_class) >>>>>> + phy_core_init(); >>>>> >>>>> why don't you setup the class on module_init ? Then this would be a >>>>> terrible error condition here :-) >>>> >>>> This is for the case where the PHY driver gets loaded before the PHY >>>> framework. I could have returned EPROBE_DEFER here instead I thought >>>> will have it this way. >>> >>> looks a bit weird IMO. Is it really possible for PHY to load before ? >> >> yeah. it actually happened when I tried with beagle and had all the >> modules as built-in. Because twl4030 has subsys_initcall(), it loads >> before PHY framework. > > that's a bug in twl4030.
right. Will fix it.
Thanks Kishon
| |