Messages in this thread | | | Date | Tue, 30 Apr 2013 19:40:51 +0100 | From | Mark Brown <> | Subject | Re: [PATCH 1/1] ASoC: McASP: Add device tree binding for defining separate clock and sync used by tx and rx. |
| |
On Tue, Apr 30, 2013 at 12:07:18PM +0200, Marek Belisko wrote: > Add new property tx-rx-clk-separate which we can distinquish between common > and separate clock for tx and rx blocks.
So, this is a sensible thing to have and in fact the core already has the symmetric_rates flag for this. This says two things to me. One is that this patch ought to at least set the symmetric_rates flag so that the core can tell applications that we can't set different rates in each direction. The other is that this probably ought to be a generic property for dai_links so that we can just set this for any driver - even if the driver doesn't need to do anything it still matters to the application layer.
What I'd suggest is adding code to check if symmetric_rates is set for the DAI link and then key off that and then a generic DT thing (or just set it in the machine driver for now if that makes sense) to enable that for your board or boards. machine driver). [unhandled content-type:application/pgp-signature] | |