Messages in this thread | | | Date | Tue, 30 Apr 2013 19:30:35 +0100 | From | Mark Brown <> | Subject | Re: [PATCH 2/3] ASoC: ux500: move clock controls to ab8500-codec |
| |
On Tue, Apr 30, 2013 at 04:09:53PM +0200, Fabio Baltieri wrote: > Move ab8500 clock control definitions to the ab8500 codec driver, > leaving only card specific setting in mop500_ab8500_ctrls.
So, if this is some generic thing and not some weird stuff for the card this really reopens the question about why this is done with user visible controls...
> static struct snd_kcontrol_new ab8500_ctrls[] = { > + /* Digital interface - Clocks */ > + SOC_SINGLE("Digital Interface Master Generator Switch", > + AB8500_DIGIFCONF1, AB8500_DIGIFCONF1_ENMASTGEN, > + 1, 0), > + SOC_SINGLE("Digital Interface 0 Bit-clock Switch", > + AB8500_DIGIFCONF1, AB8500_DIGIFCONF1_ENFSBITCLK0, > + 1, 0), > + SOC_SINGLE("Digital Interface 1 Bit-clock Switch", > + AB8500_DIGIFCONF1, AB8500_DIGIFCONF1_ENFSBITCLK1, > + 1, 0),
...this is all stuff that is normally figured out automatically by the drivers, we know when the audio interface is in use and hence when it needs to be clocked. [unhandled content-type:application/pgp-signature] | |