lkml.org 
[lkml]   [2013]   [Apr]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 2/3] posix_timers: Defer per process timer stop after timers processing
From
Date

>
> > Maybe the condition around the posix_cpu_timer_schedule() block inside
> > cpu_timer_fire() could even be a good candidate for 'unlikely'
> > qualifier.
>
> Well, cpu_timer_fire() is probably not a fast path. So helping branch
> prediction there probably won't have much measurable effect in practice.
>
Frederic, I'm totally sure that you are right on the measurable effect.
When I did propose the 'unlikely' qualifier, please note, that I also
had a documentary purpose in mind.

Would you have searched the 'likely' path that does
posix_cpu_timer_schedule() when you did modify the code if the
'unlikely' tag would have been present?

Greetings,
Olivier





\
 
 \ /
  Last update: 2013-04-30 20:21    [W:1.363 / U:0.444 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site