lkml.org 
[lkml]   [2013]   [Apr]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: linux-next build error (at91) - use of bool in mach/arch.h
On Tue, 30 Apr 2013, Stefano Stabellini wrote:

> On Tue, 30 Apr 2013, Geert Uytterhoeven wrote:
> > On Tue, Apr 30, 2013 at 11:33 AM, Nicolas Ferre <nicolas.ferre@atmel.com> wrote:
> > > So, I am wondering if the best correction is to add the types.h header file
> > > in the asm/mach/arch.h file, like this:
> > >
> > > --- a/arch/arm/include/asm/mach/arch.h
> > > +++ b/arch/arm/include/asm/mach/arch.h
> > > @@ -8,6 +8,8 @@
> > > * published by the Free Software Foundation.
> > > */
> > >
> > > +#include <linux/types.h>
> > > +
> > > #ifndef __ASSEMBLY__
> > >
> > > struct tag;
> > >
> > > or if a better option would be to re-arrange the include directives in
> > > various at91xxx_devices.c files?
> >
> > Include files should be self-contained, so asm/mach/arch.h is the right place.
>
> Nicolas,
> are you happy to come up with a proper patch to fix the issue?

I'd prefer if you just folded the above include into the original patch,
unless this has been pulled already.


Nicolas


\
 
 \ /
  Last update: 2013-04-30 17:42    [W:0.115 / U:0.152 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site