| From | "Rafael J. Wysocki" <> | Subject | Re: [PATCH 2/3 RFC] Driver core: Use generic offline/online for CPU offline/online | Date | Tue, 30 Apr 2013 14:01:10 +0200 |
| |
On Monday, April 29, 2013 04:11:06 PM Greg Kroah-Hartman wrote: > On Mon, Apr 29, 2013 at 02:28:02PM +0200, Rafael J. Wysocki wrote: > > From: Rafael J. Wysocki <rafael.j.wysocki@intel.com> > > > > Rework the CPU hotplug code in drivers/base/cpu.c to use the > > generic offline/online support introduced previously instead of > > its own CPU-specific code. > > > > For this purpose, modify cpu_subsys to provide offline and online > > callbacks for CONFIG_HOTPLUG_CPU set and remove the code handling > > the CPU-specific 'online' sysfs attribute. > > > > This modification is not supposed to change the user-observable > > behavior of the kernel (i.e. the 'online' attribute will be present > > in exactly the same place in sysfs and should trigger exactly the > > same actions as before). > > > > Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com> > > --- > > drivers/base/cpu.c | 62 ++++++++++++----------------------------------------- > > 1 file changed, 15 insertions(+), 47 deletions(-) > > Very nice, I like reductions like this :)
Thanks!
So I guess the patches make sense to you overall?
Rafael
-- I speak only for myself. Rafael J. Wysocki, Intel Open Source Technology Center.
|