lkml.org 
[lkml]   [2013]   [Apr]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 6/7] usb: phy: tegra: Add error handling & clean up.
On 04/03/2013 02:41 AM, Venu Byravarasu wrote:
> Check return values from all GPIO APIs and handle errors accordingly.
> Remove clk_disable_unprepare which is no more needed.

checkpatch fails:

> WARNING: line over 80 characters
> #27: FILE: drivers/usb/phy/phy-tegra-usb.c:547:
> + dev_err(phy->dev, "gpio %d direction not set\n", phy->reset_gpio);
>
> WARNING: line over 80 characters
> #34: FILE: drivers/usb/phy/phy-tegra-usb.c:553:
> + dev_err(phy->dev, "gpio %d direction not set\n", phy->reset_gpio);
>
> total: 0 errors, 2 warnings, 72 lines checked
>
> 0006-usb-phy-tegra-Add-error-handling-clean-up.patch has style problems, please review.



\
 
 \ /
  Last update: 2013-04-03 22:41    [W:0.138 / U:1.044 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site