Messages in this thread | | | Date | Wed, 3 Apr 2013 18:48:07 +0300 | From | Felipe Balbi <> | Subject | Re: [PATCH v5 2/6] usb: phy: omap-usb2: use the new generic PHY framework |
| |
Hi,
On Wed, Apr 03, 2013 at 02:55:47PM +0000, Arnd Bergmann wrote: > On Wednesday 03 April 2013, Felipe Balbi wrote: > > const ? Maybe provide a: > > > > #define DEFINE_PHY_OPS(name) \ > > const struct phy_ops #name_phy_ops = { > > > > macro ? This will force people to add the const keyword :-) > > Forcing people to use const structures is good, but I think it would be > better without the macro, just by marking the argument in > devm_phy_create() as const.
that won't force the definition of the struct to be const, however. But I get your point.
-- balbi [unhandled content-type:application/pgp-signature] | |