lkml.org 
[lkml]   [2013]   [Apr]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH v7 06/14] spi/spi-atmel: add flag to controller data for lock operations
Date
Hi, Mark,

> -----Original Message-----
> From: Mark Brown [mailto:broonie@opensource.wolfsonmicro.com]
> Sent: 2013年4月1日 21:46
> To: Yang, Wenyou
> Cc: linux-arm-kernel@lists.infradead.org; grant.likely@secretlab.ca;
> richard.genoud@gmail.com; plagnioj@jcrosoft.com; Ferre, Nicolas; Lin, JM;
> spi-devel-general@lists.sourceforge.net; linux-kernel@vger.kernel.org
> Subject: Re: [PATCH v7 06/14] spi/spi-atmel: add flag to controller data for lock
> operations
>
> On Tue, Mar 19, 2013 at 03:46:03PM +0800, Wenyou Yang wrote:
>
> > +static void atmel_spi_lock(struct atmel_spi *as) {
> > + spin_lock_irqsave(&as->lock, as->flags); }
>
> Coding style.
I will change it in next version.

>
> > - spin_unlock(&as->lock);
> > + atmel_spi_unlock(as);
> > msg->complete(msg->context);
> > - spin_lock(&as->lock);
> > + atmel_spi_lock(as);
>
> This replaces non-irqsave versions with irqsave versions of the lock.
> Is this safe/correct? If it is I'd have expected some sort of mention of it in the
> commit log.
I will add some commit log.

Best Regards,
Wenyou Yang
\
 
 \ /
  Last update: 2013-04-03 08:01    [W:1.167 / U:0.224 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site