lkml.org 
[lkml]   [2013]   [Apr]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH 3/9 v2] f2fs: remove redundant lock_page calls
From
2013/4/3, Jaegeuk Kim <jaegeuk.kim@samsung.com>:
Hi. Jaegeuk.
> Hi,
>
> Agreed, and send v2.
>
> Change log from v1:
> o remain read_node_page and remove the lock part
>
> From 04006aecac2882c574fe8a7de926bc52c73a8ad1 Mon Sep 17 00:00:00 2001
> From: Jaegeuk Kim <jaegeuk.kim@samsung.com>
> Date: Sun, 31 Mar 2013 12:47:20 +0900
> Subject: [PATCH] f2fs: remove redundant lock_page calls
> Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
> linux-f2fs-devel@lists.sourceforge.net
>
> In get_node_page, we do not need to call lock_page all the time.
>
> If the node page is cached as uptodate,
>
> 1. grab_cache_page locks the page,
> 2. read_node_page unlocks the page, and
> 3. lock_page is called for further process.
>
> Let's avoid this.
>
> Signed-off-by: Jaegeuk Kim <jaegeuk.kim@samsung.com>
Yes, Looks good!
Reviewed-by: Namjae Jeon <namjae.jeon@samsung.com>

Thanks.
> ---


\
 
 \ /
  Last update: 2013-04-03 11:01    [W:0.057 / U:0.744 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site