lkml.org 
[lkml]   [2013]   [Apr]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 1/2] acpi: video: add function to support unregister backlight
From
Date
於 五,2013-04-26 於 13:24 +0800,Aaron Lu 提到:
> On 04/22/2013 08:39 PM, Chun-Yi Lee wrote:
> > From: "Lee, Chun-Yi" <jlee@suse.com>
> >
> > There have situation we unregister whole acpi/video driver by downstream driver
> > just want to remove backlight control interface of acpi/video. It caues we lost
> > other functions of acpi/video, e.g. transfer acpi event to input event.
> >
> > So, this patch add a new function, find_video_unregister_backlight, it provide
> > the interface let downstream driver can tell acpi/video to unregister backlight
> > interface of all acpi video devices. Then we can keep functions of acpi/video
> > but only remove backlight support.
> >
> > Reference: bko#35622
> > https://bugzilla.kernel.org/show_bug.cgi?id=35622
> >
> > Tested-by: Andrzej Krentosz <endrjux@gmail.com>
> > Cc: Carlos Corbacho <carlos@strangeworlds.co.uk>
> > Cc: Matthew Garrett <mjg@redhat.com>
> > Cc: Dmitry Torokhov <dtor@mail.ru>
> > Cc: Corentin Chary <corentincj@iksaif.net>
> > Cc: Rafael J. Wysocki <rjw@sisk.pl>
> > Cc: Aaron Lu <aaron.lu@intel.com>
> > Cc: Thomas Renninger <trenn@suse.de>
> > Signed-off-by: Lee, Chun-Yi <jlee@suse.com>
> > ---
> > drivers/acpi/video.c | 46 ++++++++++++++++++++++++++++++++++++++++++++++
> > include/acpi/video.h | 2 ++
> > 2 files changed, 48 insertions(+)
> >
> > diff --git a/drivers/acpi/video.c b/drivers/acpi/video.c
> > index 313f959..acd2e7a 100644
> > --- a/drivers/acpi/video.c
> > +++ b/drivers/acpi/video.c
> > @@ -1793,6 +1793,52 @@ static int __init intel_opregion_present(void)
> > return opregion;
> > }
> >
> > +static acpi_status
> > +find_video_unregister_backlight(acpi_handle handle, u32 lvl, void *context,
> > + void **rv)
> > +{
> > + struct acpi_device *acpi_dev;
> > + struct acpi_video_bus *video = NULL;
> > + struct acpi_video_device *dev, *next;
> > +
> > + if (acpi_bus_get_device(handle, &acpi_dev))
> > + return AE_OK;
> > +
> > + if (!acpi_match_device_ids(acpi_dev, video_device_ids)) {
> > + video = acpi_driver_data(acpi_dev);
> > + acpi_video_bus_stop_devices(video);
> > + mutex_lock(&video->device_list_lock);
> > + list_for_each_entry_safe(dev, next, &video->video_device_list,
> > + entry) {
> > + if (dev->backlight) {
> > + backlight_device_unregister(dev->backlight);
> > + dev->backlight = NULL;
> > + kfree(dev->brightness->levels);
> > + kfree(dev->brightness);
> > + }
>
> The cooling_dev should also be unregistered I think.
>
> Thanks,
> Aaron
>

Yes, you are right!

Unregistering backlight interface of video devices means the backlight
control functions broken, so it can not used for throttling.

I will unregister cooling_dev in v2 patch.


Thanks a lot!
Joey Lee

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2013-04-29 12:21    [W:0.675 / U:0.880 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site