Messages in this thread | | | Date | Mon, 29 Apr 2013 11:38:51 -0700 | From | Greg KH <> | Subject | Re: [GIT PATCH] char/misc patches for 3.10-rc1 |
| |
On Mon, Apr 29, 2013 at 11:28:40AM -0700, Linus Torvalds wrote: > On Mon, Apr 29, 2013 at 9:21 AM, Greg KH <gregkh@linuxfoundation.org> wrote: > > > > Here's the big char / misc driver update for 3.10-rc1 > > Ugh. What the f*ck is up with stuff like this: > > > drivers/ssbi/Kconfig | 16 + > > drivers/ssbi/Makefile | 1 + > > drivers/ssbi/ssbi.c | 379 ++++++++++++++ > > Seriously? "ssbi" is such a major driver subsystem that it needs its > own subdirectory at the top level? > > We can't just go adding random single drivers at the top level. Now, > giving it a subdirectory of its own is certainly fine (there should be > more drivers that decide "I'll put my files away from others", but it > should be under drivers/misc/ or something. There's no way this is at > the same level as "networking" or "pci".
It's a "bus" type, that has individual drivers connecting to it. I'm pretty sure that David (now on to:) has a bunch more drivers queued up for this directory, right David?
Now if we want to have a drivers/buses/ where we put these things, that's fine with me, but so far, we seem to put new bus types directly in drivers/
thanks,
greg k-h
| |