lkml.org 
[lkml]   [2013]   [Apr]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2] firewire: Fix 'failed to read phy reg' on FW643 rev8
On Mar 26 Peter Hurley wrote:
> --- a/drivers/firewire/ohci.c
> +++ b/drivers/firewire/ohci.c
> @@ -2268,8 +2268,8 @@ static int ohci_enable(struct fw_card *card,
> OHCI1394_HCControl_postedWriteEnable);
> flush_writes(ohci);
>
> - for (lps = 0, i = 0; !lps && i < 3; i++) {
> - msleep(50);
> + for (lps = 0, i = 0; !lps && i < 150; i++) {
> + msleep(1);
> lps = reg_read(ohci, OHCI1394_HCControlSet) &
> OHCI1394_HCControl_LPS;
> }

This duplicates a mistake (?) that we already did a few times elsewhere in
firewire-ohci: msleep(1) may put the thread to sleep for much, much longer
than 1 millisecond. I will propose a patch soon.
--
Stefan Richter
-=====-===-= -=-- ===--
http://arcgraph.de/sr/


\
 
 \ /
  Last update: 2013-04-28 14:41    [W:0.042 / U:0.616 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site