Messages in this thread | | | Date | Sun, 28 Apr 2013 14:15:59 +0200 | From | Stefan Richter <> | Subject | Re: [PATCH v2] firewire: Fix 'failed to read phy reg' on FW643 rev8 |
| |
On Mar 26 Peter Hurley wrote: > --- a/drivers/firewire/ohci.c > +++ b/drivers/firewire/ohci.c > @@ -2268,8 +2268,8 @@ static int ohci_enable(struct fw_card *card, > OHCI1394_HCControl_postedWriteEnable); > flush_writes(ohci); > > - for (lps = 0, i = 0; !lps && i < 3; i++) { > - msleep(50); > + for (lps = 0, i = 0; !lps && i < 150; i++) { > + msleep(1); > lps = reg_read(ohci, OHCI1394_HCControlSet) & > OHCI1394_HCControl_LPS; > }
This duplicates a mistake (?) that we already did a few times elsewhere in firewire-ohci: msleep(1) may put the thread to sleep for much, much longer than 1 millisecond. I will propose a patch soon. -- Stefan Richter -=====-===-= -=-- ===-- http://arcgraph.de/sr/
| |