lkml.org 
[lkml]   [2013]   [Apr]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH] PCI: Fix racing for pci device removing via sysfs
On Fri, Apr 26, 2013 at 2:20 PM, Yinghai Lu <yinghai@kernel.org> wrote:
> On Fri, Apr 26, 2013 at 9:28 AM, Bjorn Helgaas <bhelgaas@google.com> wrote:
>> This is a gross hack. Iterating through all known pci_devs to see if
>> this one still exists?
>>
>> I reproduced the original problem, applied this patch, and verified
>> that it avoids the original crash.
>>
>> However, it's still incorrect because now you're looking at pdev after
>> it's been freed. With CONFIG_SLUB_DEBUG_ON=y, the removal still causes
>> a crash in remove_callback().
>>
>
> Yes, there is small window, that could have bus and dev get freed...
>
> Please check attached that should address your concerns.

You can't be serious. This is a disgusting mess. Checking a list
pointer for LIST_POISON1? As far as I'm concerned, this is a waste of
my time.

Bjorn


\
 
 \ /
  Last update: 2013-04-26 23:21    [W:0.050 / U:0.456 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site