lkml.org 
[lkml]   [2013]   [Apr]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/2] Fix perf LBR filtering
> 
> OK, so how about we use something like:
>
> is_kernel_text() || is_module_text_address()

is_module_text_address() has to walk all modules.
A random system with a distro kernel I checked has 101 modules loaded.

16 * 101 = too much

I don't think you want to spend that many cycles in the NMI
handler for a dubious feature. Ok in theory you could
add something with binary search, but that would be quite
a bit of effort and it would be probably challenging
to do that all NMI safe.

Also it wouldn't work for all these new kernel JITs people
are doing of course.

Still think my patch is the best so far? (plus the missing
root check)

-Andi
--
ak@linux.intel.com -- Speaking for myself only.


\
 
 \ /
  Last update: 2013-04-26 22:21    [W:0.691 / U:0.572 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site