lkml.org 
[lkml]   [2013]   [Apr]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [tip:perf/core] perf/x86/intel/P4: Robistify P4 PMU types
On Fri, Apr 26, 2013 at 07:20:46AM -0700, tip-bot for Ingo Molnar wrote:
> Commit-ID: 5ac2b5c2721501a8f5c5e1cd4116cbc31ace6886
> Gitweb: http://git.kernel.org/tip/5ac2b5c2721501a8f5c5e1cd4116cbc31ace6886
> Author: Ingo Molnar <mingo@kernel.org>
> AuthorDate: Wed, 24 Apr 2013 09:26:30 +0200
> Committer: Ingo Molnar <mingo@kernel.org>
> CommitDate: Fri, 26 Apr 2013 09:31:41 +0200
>
> perf/x86/intel/P4: Robistify P4 PMU types
>
> Linus found, while extending integer type extension checks in the
> sparse static code checker, various fragile patterns of mixed
> signed/unsigned 64-bit/32-bit integer use in perf_events_p4.c.
>
> The relevant hardware register ABI is 64 bit wide on 32-bit
> kernels as well, so clean it all up a bit, remove unnecessary
> casts, and make sure we use 64-bit unsigned integers in these
> places.
>
> [ Unfortunately this patch was not tested on real P4 hardware,
> those are pretty rare already. If this patch causes any
> problems on P4 hardware then please holler ... ]

I have a P4 and I turn it on from time to time when it's cold in the
room :-).

Any particular tests you want me to run on it?

processor : 0
vendor_id : GenuineIntel
cpu family : 15
model : 2
model name : Intel(R) Pentium(R) 4 CPU 2.60GHz

--
Regards/Gruss,
Boris.

Sent from a fat crate under my desk. Formatting is fine.
--


\
 
 \ /
  Last update: 2013-04-26 19:01    [W:0.375 / U:0.168 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site