Messages in this thread | | | Date | Fri, 26 Apr 2013 02:02:15 -0700 | Subject | Re: [GIT PULL] x86 fixes for 3.9 | From | Michel Lespinasse <> |
| |
On Fri, Apr 26, 2013 at 1:49 AM, Matt Fleming <matt.fleming@intel.com> wrote: > On 26/04/13 08:43, Michel Lespinasse wrote: >> Still seeing the crash. >> >> I went and compared the crash dump with the vmlinux disassembly; the >> issue is a NULL pointer dereference in list_for_each_entry_safe(). >> list_empty() checks that the head node points to itself, but here the >> head node has NULL. I think this may be due to gsmi_init() being >> called before efivars_init(). Not sure what's the proper fix though. > > Ohh... I see what you mean. The bug is in variable_is_present() because > it accesses __efivars directly, which a) isn't the struct efivars gsmi.c > uses and b) hasn't been initialised. Something like this might work.
[... skipping patch ...]
Yes, this one fixes it. Thanks !
-- Michel "Walken" Lespinasse A program is never fully debugged until the last user dies.
| |