Messages in this thread | | | Date | Thu, 25 Apr 2013 10:01:47 +0100 | From | Will Deacon <> | Subject | Re: [PATCH 3.8-stable] ARM: 7690/1: mm: fix CONFIG_LPAE typos |
| |
On Thu, Apr 25, 2013 at 09:20:44AM +0100, Paul Bolle wrote: > On Thu, 2013-04-25 at 17:02 +0900, Jonghwan Choi wrote: > > This patch looks like it should be in the 3.8-stable tree, should we apply > > it? > > That would be only the setup.c chunk. That fixes a typo introduced in > v3.4 (see commit e5ab85800820edd907d3f43f285e1232f84d5a41 > ("ARM: 7382/1: mm: truncate memory banks to fit in 4GB space for classic > MMU")). So, if that chunk is deemed appropriate for stable, you could > consider the v3.4.y longterm tree too.
Even then, I don't think it's worth backporting this patch. membank->start and membank->size are phys_addr_t, so with LPAE enabled, this check won't trigger anyway. The #ifndef is just there for readability really (since the printk message explicitly refers to 32-bit physical addresses).
So I wouldn't bother with this.
Will
| |