Messages in this thread | | | Date | Wed, 24 Apr 2013 23:40:14 -0700 | Subject | Re: [PATCH V3 0/9] mtd: add datasheet's ECC information to nand_chip{} | From | Brian Norris <> |
| |
Hi Huang,
On Tue, Apr 23, 2013 at 1:54 AM, Huang Shijie <b32955@freescale.com> wrote: > v2 --> v3: > [0] add a new patch to define the semantics of the two fields. > [1] Use the Change Read Column command to remove the "last" argument. > [2] simplify the onfi_feature(). > [3] Use kmalloc() to replace kcalloc(). > [4] others.
Please see especially my comment on your usage of nand_command_lp. But other than that, I think that by the time we get to v4, this series should be good. Anyway, I'll try to reserve any more nitpick-y comments for minor things to my own follow-up patch(es). Thanks for the work.
Brian
| |