lkml.org 
[lkml]   [2013]   [Apr]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] mfd: vexpress: Handle pending config transactions
From
Date
On Thu, 2013-04-25 at 14:02 +0100, Jon Medhurst (Tixy) wrote:
> > + while (!list_empty(&bridge->transactions)) {
> > + trans = list_first_entry(&bridge->transactions,
> > + struct vexpress_config_trans, list);
> >
> > - bridge->info->func_exec(trans->func->func, trans->offset,
> > - trans->write, trans->data);
> > + vexpress_config_dump_trans("Executing pending", trans);
> > + status = bridge->info->func_exec(trans->func->func,
> > + trans->offset, trans->write, trans->data);
> > +
> > + if (status == VEXPRESS_CONFIG_STATUS_DONE)
> > + vexpress_config_dump_trans("Finished pending", trans);
> > + else
> > + break;
>
> For each transaction we execute in this loop, don't we also need to do
> the actions vexpress_config_complete does? E.g.
>
> trans->status = status;
> list_del(&trans->list);
> complete(&trans->completion);
>
> except in the case status==VEXPRESS_CONFIG_STATUS_WAIT.

You're completely right. I shouldn't have write this code as the last
thing in the afternoon...

Will send v2.

Paweł


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2013-04-25 17:01    [W:0.048 / U:0.272 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site