lkml.org 
[lkml]   [2013]   [Apr]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [ PATCH ] Memory leak fix for bug 57101.
On 2013/4/25 18:05, Anurup m wrote:
> Hi All,
>
> There is a kernel memory leak observed when the proc file /proc/fs/fscache/stats is read.
> The reason is that in fscache_stats_open, single_open is called and respective release function is not called during release.
> Hence fix with correct release function - single_release. The patch is as below
>

The fix is obviously corect, but the patch is mangled so you should configure your
email client properly. Read Documention/email-clients.txt.

And when you've done that, remember Cc maintainers when you resend this patch, i.e.
David Howells <dhowells@redhat.com> and Andrew Morton <akpm@linux-foundation.org>
in this case.

> diff -uprN -X linux-3.9-rc8-vanilla/Documentation/dontdiff linux-3.9-rc8-vanilla/fs/fscache/stats.c linux-3.9-rc8.mod/fs/fscache/stats.c
> --- linux-3.9-rc8-vanilla/fs/fscache/stats.c 2013-04-22 03:08:45.000000000 +0530
> +++ linux-3.9-rc8.mod/fs/fscache/stats.c 2013-04-24 23:03:31.531296160 +0530
> @@ -287,5 +287,5 @@ const struct file_operations fscache_sta
> .open = fscache_stats_open,
> .read = seq_read,
> .llseek = seq_lseek,
> - .release = seq_release,
> + .release = single_release,

Look the tab was replaced with spaces.



\
 
 \ /
  Last update: 2013-04-25 14:01    [W:0.084 / U:0.332 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site