lkml.org 
[lkml]   [2013]   [Apr]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH 05/14] perf tools: Introduce new 'ftrace' tool
Date
On Wed, 24 Apr 2013 16:09:18 +0200, Jiri Olsa wrote:
> On Tue, Apr 23, 2013 at 05:31:03PM +0900, Namhyung Kim wrote:
>> From: Namhyung Kim <namhyung.kim@lge.com>
>> +out:
>> + put_tracing_file(file);
>> + return ret;
>> +}
>> +
>> +static int reset_tracing_files(struct perf_ftrace *ftrace __maybe_unused)
>> +{
>> + if (write_tracing_file("tracing_on", "0") < 0)
>> + return -1;
>> +
>> + if (write_tracing_file("current_tracer", "nop") < 0)
>> + return -1;
>> +
>> + if (write_tracing_file("set_ftrace_pid", " ") < 0)
>> + return -1;
>
> I think we want to reset set_ftrace_pid file as well
> probably to -1..
>
> if I'm tracing command with this file having wrong CPU(s)
> I dont get any data..

Not sure I understood what you mean exactly.

Do you mean it should be changed to

if (write_tracing_file("set_ftrace_pid", "-1") < 0)

? It seems it's the right thing to do for compatibility.

Thanks,
Namhyung


\
 
 \ /
  Last update: 2013-04-25 08:21    [W:0.085 / U:1.116 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site