Messages in this thread | | | Date | Thu, 25 Apr 2013 17:24:09 +0800 | From | Xiao Guangrong <> | Subject | Re: [PATCH v2 3/6] KVM: MMU: make return value of mmio page fault handler more readable |
| |
On 04/24/2013 09:34 PM, Gleb Natapov wrote:
>> diff --git a/arch/x86/kvm/mmu.h b/arch/x86/kvm/mmu.h >> index 2adcbc2..6b4ba1e 100644 >> --- a/arch/x86/kvm/mmu.h >> +++ b/arch/x86/kvm/mmu.h >> @@ -52,6 +52,20 @@ >> >> int kvm_mmu_get_spte_hierarchy(struct kvm_vcpu *vcpu, u64 addr, u64 sptes[4]); >> void kvm_mmu_set_mmio_spte_mask(u64 mmio_mask); >> + >> +/* >> + * Return values of handle_mmio_page_fault_common: >> + * RET_MMIO_PF_EMU: it is a real mmio page fault, emulate the instruction >> + * directly. >> + * RET_MMIO_PF_RETRY: let CPU fault again on the address. >> + * RET_MMIO_PF_BUG: bug is detected. >> + */ >> +enum { >> + RET_MMIO_PF_EMU = 1, > Make it RET_MMIO_PF_EMULATE please.
Good to me, will do.
Thanks!
| |