Messages in this thread | | | Date | Wed, 24 Apr 2013 08:52:12 +0100 | From | Lee Jones <> | Subject | Re: [PATCH] ARM: ux500: Supply a DTS file for the u8540 platform |
| |
On Tue, 23 Apr 2013, Linus Walleij wrote:
> On Thu, Apr 4, 2013 at 9:29 AM, Lee Jones <lee.jones@linaro.org> wrote: > > > This is a skeleton DTS file which only enables serial. Just using > > this simple file yields a terminal when booting u8540. > > > > Signed-off-by: Lee Jones <lee.jones@linaro.org> > > Now, wait... this doesn't work.
This is very strange and not what I see in my branch.
> > +/ { > > + model = "ST-Ericsson U8540 platform with Device Tree"; > > + compatible = "st-ericsson,u8540"; > > + > > + memory { > > + reg = <0x00000000 0x20000000>; > > + }; > > Funny whitespace. Use tabs ...
This a single tab in my branch/editor.
> > + soc-u9500 { > > Please rename this not just "soc"
Done.
> > + uart@80120000 { > > + status = "okay"; > > + }; > > + > > + uart@80121000 { > > + status = "okay"; > > + }; > > + > > + uart@80007000 { > > + status = "okay"; > > + }; > > + }; > > +}; > > The whitespace looks a bit funny compared to the > old patch, what happened here? > > It also has the side effect that patch 5/9 does not > apply... By the way, since I already applied 4/9, please > squash 5/9 into this patch to avoid problems.
It's quite common for issues to occur when patches are taken out-of-order. As I work with topic branches, my preference would normally be to fix issues with the patch-set as a whole until Acks are obtained for all of the patches, then either send a pull-request or to have all of the patches taken from the MLs in order.
> Finally, please patch arch/arm/boot/dts/Makefile > in the obvious way so that the DTB gets compiled.
Ah yes. Good spot.
-- Lee Jones Linaro ST-Ericsson Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |