Messages in this thread | | | Date | Wed, 24 Apr 2013 13:45:06 -0700 | Subject | Re: [PATCH v2 0/8] powerpc/pseries: Nvram-to-pstore | From | Kees Cook <> |
| |
On Tue, Apr 23, 2013 at 11:19 PM, Aruna Balakrishnaiah <aruna@linux.vnet.ibm.com> wrote: > Currently the kernel provides the contents of p-series NVRAM only as a > simple stream of bytes via /dev/nvram, which must be interpreted in user > space by the nvram command in the powerpc-utils package. This patch set > exploits the pstore subsystem to expose each partition in NVRAM as a > separate file in /dev/pstore. For instance Oops messages will stored in a > file named [dmesg-nvram-2]. > > Changes from v1: > - Reduce #ifdefs by and remove forward declarations of pstore callbacks > - Handle return value of nvram_write_os_partition > - Remove empty pstore callbacks and register pstore only when pstore > is configured > > --- > > Aruna Balakrishnaiah (8): > powerpc/pseries: Remove syslog prefix in uncompressed oops text > powerpc/pseries: Add version and timestamp to oops header > powerpc/pseries: Introduce generic read function to read nvram-partitions > powerpc/pseries: Read/Write oops nvram partition via pstore > powerpc/pseries: Read rtas partition via pstore > powerpc/pseries: Distinguish between a os-partition and non-os partition > powerpc/pseries: Read of-config partition via pstore > powerpc/pseries: Read common partition via pstore > > > arch/powerpc/platforms/pseries/nvram.c | 353 +++++++++++++++++++++++++++----- > fs/pstore/inode.c | 9 + > include/linux/pstore.h | 4 > 3 files changed, 313 insertions(+), 53 deletions(-)
This series looks good! Other than the naming conventions (are these new pstore types really PPC-only?) I think it's a fine addition.
Thanks!
-Kees
-- Kees Cook Chrome OS Security
| |