lkml.org 
[lkml]   [2013]   [Apr]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH 01/30] thermal: cpu_cooling: remove unused headers
Date


> -----Original Message-----
> From: linux-pm-owner@vger.kernel.org [mailto:linux-pm-
> owner@vger.kernel.org] On Behalf Of Eduardo Valentin
> Sent: Thursday, April 18, 2013 1:12 AM
> To: amit.kachhap@linaro.org
> Cc: Eduardo Valentin; Zhang, Rui; linux-pm@vger.kernel.org; linux-
> kernel@vger.kernel.org
> Subject: [PATCH 01/30] thermal: cpu_cooling: remove unused headers
> Importance: High
>
> As this code is not a module nor a platform device driver, this patch
> removes some unused header files.
>
> Cc: Zhang Rui <rui.zhang@intel.com>
> Cc: linux-pm@vger.kernel.org
> Cc: linux-kernel@vger.kernel.org
> Signed-off-by: Eduardo Valentin <eduardo.valentin@ti.com>
> ---
> drivers/thermal/cpu_cooling.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/thermal/cpu_cooling.c
> b/drivers/thermal/cpu_cooling.c index 5f5c780..778c43d 100644
> --- a/drivers/thermal/cpu_cooling.c
> +++ b/drivers/thermal/cpu_cooling.c
> @@ -20,10 +20,7 @@
> *
> *
> ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> ~~~
> */
> -#include <linux/kernel.h>
> -#include <linux/module.h>

This is still needed because of EXPORT_SYMBOL.
Or else, I get:
drivers/thermal/cpu_cooling.c:225:1: warning: data definition has no type or storage class [enabled by default]
drivers/thermal/cpu_cooling.c:225:1: warning: type defaults to int in declaration of EXPORT_SYMBOL_GPL [-Wimplicit-int]
drivers/thermal/cpu_cooling.c:225:1: warning: parameter names (without types) in function declaration [enabled by default]
drivers/thermal/cpu_cooling.c:479:1: warning: data definition has no type or storage class [enabled by default]
drivers/thermal/cpu_cooling.c:479:1: warning: type defaults to int in declaration of EXPORT_SYMBOL_GPL [-Wimplicit-int]
drivers/thermal/cpu_cooling.c:479:1: warning: parameter names (without types) in function declaration [enabled by default]
drivers/thermal/cpu_cooling.c:505:1: warning: data definition has no type or storage class [enabled by default]
drivers/thermal/cpu_cooling.c:505:1: warning: type defaults to int in declaration of EXPORT_SYMBOL_GPL [-Wimplicit-int]
drivers/thermal/cpu_cooling.c:505:1: warning: parameter names (without types) in function declaration [enabled by default]

thanks,
rui

> #include <linux/thermal.h>
> -#include <linux/platform_device.h>
> #include <linux/cpufreq.h>
> #include <linux/err.h>
> #include <linux/slab.h>
> --
> 1.8.2.1.342.gfa7285d
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-pm" in
> the body of a message to majordomo@vger.kernel.org More majordomo info
> at http://vger.kernel.org/majordomo-info.html


\
 
 \ /
  Last update: 2013-04-24 19:01    [W:0.086 / U:0.172 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site