Messages in this thread | | | From | Namhyung Kim <> | Subject | Re: [PATCH 02/14] perf util: Use evsel->name to get tracepoint_paths | Date | Wed, 24 Apr 2013 19:36:50 +0900 |
| |
On Tue, 23 Apr 2013 09:07:20 -0400, Steven Rostedt wrote: >> + >> + if (pos->name && strchr(pos->name, ':')) { >> + char *str = strchr(pos->name, ':'); > > Why not make the above into: > > if (pos->name && (str = strchr(pos->name, ':'))) { > > ?
I wanted not to have an assignment in an if condition, just for my preference. I will change it.
Thanks, Namhyung
| |