Messages in this thread | | | Subject | Re: [PATCH] input: egalax_ts: remove bogus OF dependency | From | Artem Bityutskiy <> | Date | Wed, 24 Apr 2013 08:58:27 +0300 |
| |
On Tue, 2013-04-23 at 08:37 -0700, Dmitry Torokhov wrote: > On Tue, Apr 23, 2013 at 02:09:17PM +0300, Artem Bityutskiy wrote: > > There are platforms using this driver which do not have OF. However, commit > > ae495e844a77344fdaedbb2ad97d925d096e9f0d added a Kconfig dependency on OF and > > broke OF-less setups. > > > > Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com> > > Cc: stable@vger.kernel.org [v3.7+] > > --- > > drivers/input/touchscreen/Kconfig | 2 +- > > drivers/input/touchscreen/egalax_ts.c | 2 ++ > > 2 files changed, 3 insertions(+), 1 deletions(-) > > > > diff --git a/drivers/input/touchscreen/Kconfig b/drivers/input/touchscreen/Kconfig > > index 515cfe7..d53b0d6 100644 > > --- a/drivers/input/touchscreen/Kconfig > > +++ b/drivers/input/touchscreen/Kconfig > > @@ -227,7 +227,7 @@ config TOUCHSCREEN_EETI > > > > config TOUCHSCREEN_EGALAX > > tristate "EETI eGalax multi-touch panel support" > > - depends on I2C && OF > > + depends on I2C > > No, because egalax_wake_up_device() needs OF data and with !CONFIG_OF > you'll end up using stubs, the wakeup will fail and the touchscreen will > fail probe. > > It wasn't tested, was it?
Not tested. But Ulf (the reporter of the issue) confirms it does not solve the issue.
-- Best Regards, Artem Bityutskiy
| |